yahoo-eng-team team mailing list archive

[OpenStack Infra <1527016@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/258815
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fbcf8e6b141906632af2d387767b58ece269538d
Submitter: Jenkins
Branch:    master

commit fbcf8e6b141906632af2d387767b58ece269538d
Author: lei zhang <shleiz@xxxxxxxxxx>
Date:   Thu Nov 26 23:36:05 2015 +0800

    Fix Security-rule's port should not set to 0 when Protocol is TCP/UDP
    
    security rule port can be set value 0 when protocol is TCP/UDP
    
    This patch add port check in def_validate_port_range(self, rule),when
    protocol is TCP or UDP,port value 0 should not accepted
    
    APIImpact
    Change-Id: I57836d730db602de2a6704fd11a13c74ac38a716
    Closes-Bug: #1527016


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1527016

Title:
  Security-rule's port value should 1-65535

Status in neutron:
  Fix Released

Bug description:
  When add a security from GUI and input port is 0,GUI can check this is invalid,But we can add port 0 rule from CLI
  eg:
  [root@controller extensions(keystone_admin)]# neutron security-group-rule-create 65aa027e-3808-41b8-9343-0a86092380ca --protocol TCP 
  --port_range_min 0 --port_range_max 0
  Created a new security_group_rule:
  +-------------------+--------------------------------------+
  | Field             | Value                                |
  +-------------------+--------------------------------------+
  | direction         | ingress                              |
  | ethertype         | IPv4                                 |
  | id                | f2932274-63ca-4a1b-b176-77982c773c99 |
  | port_range_max    | 0                                    |
  | port_range_min    | 0                                    |
  | protocol          | tcp                                  |
  | remote_group_id   |                                      |
  | remote_ip_prefix  |                                      |
  | security_group_id | 65aa027e-3808-41b8-9343-0a86092380ca |
  | tenant_id         | 2c0482cd169a4c1a8b16ab34e30b3984     |
  +-------------------+--------------------------------------+

  so we should check port value range is 1-65535 from def
  convert_validate_port_value(port)

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1527016/+subscriptions