yahoo-eng-team team mailing list archive

[OpenStack Infra <1532258@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/265401
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c4aa41a25a7828adddcd0f314082b63e78a23676
Submitter: Jenkins
Branch:    master

commit c4aa41a25a7828adddcd0f314082b63e78a23676
Author: Akihiro Motoki <motoki@xxxxxxxxxxxxx>
Date:   Sat Jan 9 03:35:05 2016 +0900

    Make neutron-debug command follow cliff command convention
    
    In the guideline of cliff command, developers implementing
    commands should override take_action() rather than run().
    The similar effort is being done in neutronclient side and
    this fix is required to complete the effort.
    
    Logger definition in each command class is no longer needed.
    This commit also drops them.
    
    Closes-Bug: #1532258
    Change-Id: I613b7e18b3c058568fc3669ad1524e60a93eb9f8


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1532258

Title:
  neutronclient commands do not follow cliff command guideline

Status in neutron:
  Fix Released
Status in python-neutronclient:
  In Progress

Bug description:
  The docstring of cliff.command.Command says  that developers
  implementing commands should override take_action instead of run [1].

  neutornclient DeleteCommand and UpdateCommand override run().
  take_action() should be used.

  In addition, neutronclient.common.command.OpenStackCommand provides an
  extra and meaningless layer and interface get_data(). get_data()
  provides no addition value. take_action() should be used.
  CreateCommand, ShowCommand and ListCommand are affected.

  [1]
  https://github.com/openstack/cliff/blob/master/cliff/command.py#L39-L52

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1532258/+subscriptions