yahoo-eng-team team mailing list archive

[OpenStack Infra <1531734@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/264631
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6698d26fbaf68ab9c45ae267c27ba9644ef674c0
Submitter: Jenkins
Branch:    master

commit 6698d26fbaf68ab9c45ae267c27ba9644ef674c0
Author: Rajat Vig <rajatv@xxxxxxxxxxxxxxxx>
Date:   Wed Jan 6 22:53:38 2016 -0800

    Set target to _self for Header Links
    
    Angular Panels have enabled ngRoute and HTML5 which
    allows Angular to handle routing which makes all
    routes to pass via Angular.
    
    Links that do not have route defintion as a result stop
    working.
    This can be fixed by specifying the target="_self" on the <a> tags.
    
    This is already in place for the Sidebar. It needs to done for the
    Header Links as well.
    
    Closes-Bug: #1531734
    Change-Id: Ida76b40fdf0b66ba3ee3af4d32701974c312af57


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1531734

Title:
  Header Links are not working in Angularized Panels

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Location Provider is now set in Horizon which now allows for HTML5
  based routing.

  This implies all links on an Angular Panel which aren't routed in Angular using $routeProvider no longer work.
  This can be fixed by specifying the target="_self" on the <a> tags. 

  This is already in place for the Sidebar. It needs to done for the
  Header Links as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1531734/+subscriptions