← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1505843] Re: Pecan: quota management API broken

 

Reviewed:  https://review.openstack.org/234466
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5fe6f8015ac3e532c4cf95201209f49e6b69955f
Submitter: Jenkins
Branch:    master

commit 5fe6f8015ac3e532c4cf95201209f49e6b69955f
Author: Salvatore Orlando <salv.orlando@xxxxxxxxx>
Date:   Fri Sep 18 14:10:26 2015 -0700

    Pecan: fix quota management
    
    This patch fixes quota management APIs in the Pecan framework.
    To this aim:
    
    1) an ad-hoc pair of collection/item controllers are introduced
       for the quota resource; as the new controllers have been added
       in a separate module, the neutron.pecan_wsgi.controllers.utils
       module has been added as well for helpers, routines and classes
       used by all pecan controllers;
    2) the quota API extension is made pecan-aware, meaning that it
       simply returns a Pecan controller instance rather than deferring
       the task to the startup process that builds controllers using the
       home-grown WSGI framework ext manager;
    3) the quota resource is now "almost" a standard neutron resource;
       unfortunately since it does not yet have its own service plugin a
       special provision is made in the attribute population hook in
       order to ensure the object is loaded for allowing correct
       policy enforcement.
    4) Functional tests for the quota controller have been added.
    
    Closes-Bug: #1505843
    
    Change-Id: I44a1fd73f678e493d5b1163e5f183d9efdc678ac


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1505843

Title:
  Pecan: quota management API broken

Status in neutron:
  Fix Released

Bug description:
  The quota management APIs in Pecan simply do not work.

  The pecan controller framework try to treat quota as a resource, and
  even create resource and collection controllers for this resource.
  However, this fails as the plugins do not implement a quota interface.

  In the current WSGI framework indeed quota management is performed by
  a special controller which interacts directly with the driver and
  implements its own authZ logic.

  The pecan framework should implement quota management correctly,
  possibly avoiding to carry on "special" behaviours from the current
  WSGI framework

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1505843/+subscriptions


References