← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1534197] Re: advertise_mtu=True for DHCP agent when plugin does not pass .mtu attribute for networks results in agent failure

 

Reviewed:  https://review.openstack.org/267641
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=36effd66006aaf078cf652de146f35f19f56bdca
Submitter: Jenkins
Branch:    master

commit 36effd66006aaf078cf652de146f35f19f56bdca
Author: Ihar Hrachyshka <ihrachys@xxxxxxxxxx>
Date:   Thu Jan 14 16:06:20 2016 +0100

    dhcp: handle advertise_mtu=True when plugin does not set mtu values
    
    DHCP agent may be used by plugins that don't set mtu value for networks.
    Handle the case by not passing the DHCP option when network does not
    have the value set.
    
    Most plugins do set the value though, since it's enforced in base db
    plugin class.
    
    Closes-Bug: #1534197
    Change-Id: I282b3d6b81f91eb8cea901d955cbcca6ecb2a95d


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1534197

Title:
  advertise_mtu=True for DHCP agent when plugin does not pass .mtu
  attribute for networks results in agent failure

Status in neutron:
  Fix Released

Bug description:
  In that case, you would see a traceback with the following lines:

        File "neutron/agent/linux/dhcp.py", line 371, in _build_cmdline_callback
          mtu = self.network.mtu
      AttributeError: 'FakeV4Network' object has no attribute 'mtu'

  We should check whether plugin passed mtu attribute before accessing
  it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1534197/+subscriptions


References