← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1518200] Re: instance is not destroyed on source host after a successful evacuate

 

Reviewed:  https://review.openstack.org/250101
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a79ac83bae4e673a416cca4b86a3f47f4f25b0aa
Submitter: Jenkins
Branch:    master

commit a79ac83bae4e673a416cca4b86a3f47f4f25b0aa
Author: lvdongbing <dongbing.lv@xxxxxxxxxxxxxxx>
Date:   Tue Dec 1 04:33:56 2015 -0500

    Fix instance not destroyed after successful evacuation
    
    After complete evacuate action, the status of migration will change
    to 'done' from 'accepted', so the _destroy_evacuated_instances action
    in old nova-compute should consider the status 'done' to filter
    migration list when they're back up.
    
    Closes-bug: #1518200
    Co-Authored-By: Sylvain Bauza <sbauza@xxxxxxxxxx>
    
    Change-Id: Ie4825dcaa778d229922c963a96590ad5a2604257


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1518200

Title:
  instance is not destroyed on source host after a successful evacuate

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) liberty series:
  New

Bug description:
  After evacuate an instance to a new host successfully, then start the old host's nova-compute, bug the old instance not be destroyed as expected.
  See following code:
  https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L817
  nova-compute read migration record from db to get the evacuated instance and then destroy it.  It filters migration with status 'accepted'. 
  https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L2715
  After successfully evacuate instance, status of migration will change to 'done' from 'accepted' 
  So, I think we should modify 'accepted' to 'done' when filter migration record.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1518200/+subscriptions


References