← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1179607] Re: Present a better error message when the flavor creation fails

 

Reviewed:  https://review.openstack.org/266460
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b5d27265542a143da9847cf87d9e9a24229b21f5
Submitter: Jenkins
Branch:    master

commit b5d27265542a143da9847cf87d9e9a24229b21f5
Author: Lucas Palm <lapalm@xxxxxxxxxx>
Date:   Tue Jan 12 10:12:58 2016 -0600

    Improve field validation/error handling for flavor creation
    
    Currently, if a user tries to create a new flavor or rename a flavor
    to a name that already exists, a field validation error will be shown
    that tells the user that the name is already being used by another
    flavor.
    
    It seems, however, that the validation does not catch the case where the
    user enters a flavor name that is the same string but just with
    uppercase/lowercase differences.  Since this is not caught during the
    form validation, nova runs into an error later and thus throws an
    exception that leaves the user with a generic error message like
    "Unable to create flavor".
    
    To improve the form field validation and prevent the error from ever
    occurring in Nova, I switched the name comparisons to use the .lower()
    method.  This was done for both Creating and Editing Flavor names.
    
    Change-Id: I44dcd98978e57282b44fdab8f134500eb9b03881
    Closes-Bug: #1179607


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1179607

Title:
  Present a better error message when the flavor creation fails

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  When an error happens during the flavor creation thru the Horizon, the
  message "Unable to create flavor" is always presented to the user,
  without giving better directions on what caused the failure.

  Would be more useful if the message had a more meaningful text. It
  could be reached presenting the error message sent from the backend
  exception that caused the failure.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1179607/+subscriptions