yahoo-eng-team team mailing list archive

[OpenStack Infra <1534354@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/267853
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0875a411aaa111571f6f5e7ae29b5de75f1e3184
Submitter: Jenkins
Branch:    master

commit 0875a411aaa111571f6f5e7ae29b5de75f1e3184
Author: Matt Riedemann <mriedem@xxxxxxxxxx>
Date:   Thu Jan 14 14:48:40 2016 -0800

    ServerGroupsV213SampleJsonTest should actually test v2.13
    
    This API samples test was not using testscenarios properly,
    and it wasn't extending the correct test class, so it was:
    
    1. Not actually running tests.
    2. Not running tests at the correct microversion (v2.13).
    
    This fixes the testscenarios setup for the subclass and the
    API samples and templates (since it's not using subs for the
    intended project_id that was in the samples).
    
    Also fixes a typo in ApiSampleTestBaseV21.
    
    Change-Id: I27e8fce5d456914d88098c6cfabe05fa8afbc8eb
    Closes-Bug: #1534354


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1534354

Title:
  ServerGroupsV213SampleJsonTest is not actually running tests against
  the v2.13 microversion

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  There are a few issues here:

  https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_server_groups.py#L81

  class ServerGroupsV213SampleJsonTest(api_sample_base.ApiSampleTestBaseV21):
      extension_name = "os-server-groups"
      request_api_version = '2.13'
      scenarios = [('v2_13', {})]

  1. It is not extending the ServerGroupsSampleJsonTest class so it's
  not actually running any tests.

  2. The request_api_version variable isn't used, and the scenarios
  variable is not defined correctly, so it's only running against v2
  API, not the v2.13 API.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1534354/+subscriptions