← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1536214] Re: PO files broken

 

Reviewed:  https://review.openstack.org/270190
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b18c5c34229b7f401e09f77bfde3be808e0e50d5
Submitter: Jenkins
Branch:    master

commit b18c5c34229b7f401e09f77bfde3be808e0e50d5
Author: Andreas Jaeger <aj@xxxxxxxx>
Date:   Wed Jan 20 14:41:24 2016 +0100

    Validate translations
    
    Validate that translations are ok using msgfmt, so that no invalid
    ones can be imported.
    
    Closes-Bug: #1536214
    Change-Id: Ic1f106684270a8f2197e0fb2a67d6fc00535ee65


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1536214

Title:
  PO files broken

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) kilo series:
  In Progress
Status in OpenStack Compute (nova) liberty series:
  In Progress

Bug description:
  python setup.py compile_catalog fails to compile the existing
  translated files for Spanish and Turkish - both in master and liberty.

  Suggested action:
  1) Fix the strings in translation server so that next translation import gets strings that are valid
  2) Add lint check that checks that translations are valid.

  For 2: Add to tox.ini a check like it's done for keystone:
    # Check that .po and .pot files are valid.
    bash -c "find nova -type f -regex '.*\.pot?' -print0| \
             xargs -0 -n 1 msgfmt --check-format -o /dev/null"

  Change 2)  will take care that the daily translation import cannot
  import again non-valid translations. 2) should only merge once 1) is
  fixed and imported.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1536214/+subscriptions


References