← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1536892] Re: Test output full of object comparison warnings

 

Reviewed:  https://review.openstack.org/271140
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d8c0a7fac6dd37854ba8626f210002fdc94d99e4
Submitter: Jenkins
Branch:    master

commit d8c0a7fac6dd37854ba8626f210002fdc94d99e4
Author: Richard Jones <r1chardj0n3s@xxxxxxxxx>
Date:   Fri Jan 22 16:13:37 2016 +1100

    Disable unnecessary warnings from heatclient about object comparisons
    
    A recent heatclient release included a warning on comparison of
    Resource objects which is triggered in the Horizon test suite
    *a lot*.
    
    This patch raises the logging threshold to ERROR for the
    heatclient.openstack.common.apiclient.base module.
    
    Change-Id: I63c6a8475996d214eea712620d528a978e38a594
    Fixes-Bug: 1536892


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1536892

Title:
  Test output full of object comparison warnings

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Current HEAD test runs result in the following warning being spewed to
  the console:

  WARNING:heatclient.openstack.common.apiclient.base:Two objects are
  equal when all of the attributes are equal, if you want to identify
  whether two objects are same one with same id, please use
  is_same_obj() function.

  We use the equality test being warned about in our test data
  construction in openstack_dashboard/test/test_data/utils.py

  Working around it is possible, but the above warning is really very
  difficult to justify in the first place. It would be better to remove
  the warning generation completely if possible.

  The patch to heatclient adding the warning is
  https://review.openstack.org/#/c/251830/

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1536892/+subscriptions


References