← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1438822] Re: Table widget should show a default message when filtering yields no items

 

Reviewed:  https://review.openstack.org/175035
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d37f1a899679fd7efe87ffbbb0bd4d9cb4e0c44f
Submitter: Jenkins
Branch:    master

commit d37f1a899679fd7efe87ffbbb0bd4d9cb4e0c44f
Author: Cindy Lu <clu@xxxxxxxxxx>
Date:   Mon Aug 3 15:33:12 2015 -0700

    Add Angular Directive to show msg for empty tables
    
    Ideally smart-table would have a default message when filtering
    yields no results, but it does not.  This patch provides a general
    directive that allows Angular tables to specify a custom message, or
    uses a default "No items to display" message if not.
    
    To test, set DISABLED = False in
     _3031_identity_users_panel.py, and/or
     _1051_project_ng_images_panel.py and/or
     _2081_admin_flavors_panel.py
    
    Then go to the last Users panel in the Identity menu,
    last Images Panel in Project menu, respectively.
    
    Co-Authored-By: Rajat Vig <rajatv@xxxxxxxxxxxxxxxx>
    Co-Authored-By: Cindy Lu <clu@xxxxxxxxxx>
    
    Change-Id: Ia086bb791d6c74af738209795195ff3ea1860981
    Closes-bug: #1438822


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1438822

Title:
  Table widget should show a default message when filtering yields no
  items

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Currently angular tables are filterable using the smart-table feature.
  However, table widget should show a default message when filtering
  yields no items. This is currently not the case and need to be amend.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1438822/+subscriptions


References