yahoo-eng-team team mailing list archive

[OpenStack Infra <1533741@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/267248
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9a46586dcf96db567a999380dcaef02bdfd1592a
Submitter: Jenkins
Branch:    master

commit 9a46586dcf96db567a999380dcaef02bdfd1592a
Author: Ryan Rossiter <rlrossit@xxxxxxxxxx>
Date:   Thu Jan 14 00:21:02 2016 +0000

    Add tests for nova.rpc module
    
    This change adds test for the nova.rpc module, including the public
    functions and 2 classes within the module.
    
    Change-Id: I368ed5146210948c95de5a647097b98dcf8a3ca6
    Closes-bug: #1533741


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1533741

Title:
  nova.rpc module is only indirectly unit tested

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  It seems that there are no unit tests for the nova.rpc module. Because
  nova.rpc is used by many other modules, changes to it do cause UT
  failures. But it is possible to remove essential parts without failing
  any unit tests. An example of this is removing TRANSPORT.cleanup()
  from the cleanup function.

  Tests should be added for all of the public functions, along with
  tests for RequestContextSerializer for both a given base, and a null
  base.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1533741/+subscriptions