yahoo-eng-team team mailing list archive

[Zhenyu Zheng <zhengzhenyu@xxxxxxxxxx>]

Public bug reported:

In roll_back_live_migration_at_destination, we treat migrate_data as a LiveMigrateData object, but it can also be a dict:
https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5176-L5198
We have logic here :
https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5484-L5491
but we directly pass it down to driver here:
https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5512-L5514
and it has not been handled in libvirt driver:
https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6406-L6412

This will cause AttributeError.

** Affects: nova
     Importance: Undecided
     Assignee: Zhenyu Zheng (zhengzhenyu)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Zhenyu Zheng (zhengzhenyu)

** Description changed:

- In roll_back_live_migration_at_destination, we treat migrate_data as a LiveMigrateData object, but it is actually a dict:
+ In roll_back_live_migration_at_destination, we treat migrate_data as a LiveMigrateData object, but it can also be a dict:
  https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5176-L5198
  We have logic here :
  https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5484-L5491
  but we directly pass it down to driver here:
  https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5512-L5514
  and it has not been handled in libvirt driver:
  https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6406-L6412
  
  This will cause AttributeError.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1539342

Title:
  AttributeError raised during roll_back_live_migration_at_destination

Status in OpenStack Compute (nova):
  New

Bug description:
  In roll_back_live_migration_at_destination, we treat migrate_data as a LiveMigrateData object, but it can also be a dict:
  https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5176-L5198
  We have logic here :
  https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5484-L5491
  but we directly pass it down to driver here:
  https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L5512-L5514
  and it has not been handled in libvirt driver:
  https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L6406-L6412

  This will cause AttributeError.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1539342/+subscriptions