yahoo-eng-team team mailing list archive

[Drew Thorstensen <thorst@xxxxxxxxxx>]

** Changed in: nova
       Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1539029

Title:
  rollback_live_migration_at_destination fails in libvirt - expects
  migrate_data object, gets dictionary

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  The rollback_live_migration_at_destination in the libvirt nova driver
  is currently expecting the migrate_data as an object.  The object
  model for the migrate data was introduced here:

  https://github.com/openstack/nova/commit/69e01758076d0e89eddfe6945c8c7e423c862a49

  Subsequently, a change set was added to provide transitional support
  for the migrate_data object.  This currently forces all of the
  migrate_data objects that are sent to the manager to be converted to
  dictionaries:

  https://github.com/openstack/nova/commit/038dfd672f5b2be5ebe30d85bd00d09bae2993fc

  
  It looks like the rollback_live_migration_at_destination method still expects the migrate_data in object form.  However the manager passes it down as a dictionary.  Which results in this error message upon a rollback:

    File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 204, in __exit__
      six.reraise(self.type_, self.value, self.tb)
    File "/opt/stack/nova/nova/compute/manager.py", line 373, in decorated_function
      return function(self, context, *args, **kwargs)
    File "/opt/stack/nova/nova/compute/manager.py", line 5554, in rollback_live_migration_at_destination
      destroy_disks=destroy_disks, migrate_data=migrate_data)
    File "/opt/stack/nova/nova/virt/libvirt/driver.py", line 6391, in rollback_live_migration_at_destination
      is_shared_instance_path = migrate_data.is_shared_instance_path
    AttributeError: 'dict' object has no attribute 'is_shared_instance_path'

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1539029/+subscriptions