yahoo-eng-team team mailing list archive

[shihanzhang <shihanzhang@xxxxxxxxxx>]

Public bug reported:

Now for ml2 plugin,  neutron-server use faout RPC  message for port_update and port_delete, the codes as below:
    def port_update(self, context, port, network_type, segmentation_id,          physical_network):
        cctxt = self.client.prepare(topic=self.topic_port_update,fanout=True)
        cctxt.cast(context, 'port_update', port=port,
                   network_type=network_type,
                   segmentation_id=segmentation_id,
                   physical_network=physical_network)

    def port_delete(self, context, port_id):
        cctxt = self.client.prepare(topic=self.topic_port_delete, fanout=True)
        cctxt.cast(context, 'port_delete', port_id=port_id)

I think neutron-server should directly sends the RPC message to port's
binding_host, this can offload work for AMQP

** Affects: neutron
     Importance: Undecided
     Assignee: shihanzhang (shihanzhang)
         Status: New

** Description changed:

  Now for ml2 plugin,  neutron-server use faout RPC  message for port_update and port_delete, the codes as below:
-     def port_update(self, context, port, network_type, segmentation_id,
-                     physical_network):
-         cctxt = self.client.prepare(topic=self.topic_port_update,
-                                     fanout=True)
-         cctxt.cast(context, 'port_update', port=port,
-                    network_type=network_type, segmentation_id=segmentation_id,
-                    physical_network=physical_network)
+     def port_update(self, context, port, network_type, segmentation_id, physical_network):
+         cctxt = self.client.prepare(topic=self.topic_port_update,fanout=True)
+         cctxt.cast(context, 'port_update', port=port,
+                    network_type=network_type,
+                                       segmentation_id=segmentation_id,
+                    physical_network=physical_network)
  
-     def port_delete(self, context, port_id):
-         cctxt = self.client.prepare(topic=self.topic_port_delete,
-                                     fanout=True)
-         cctxt.cast(context, 'port_delete', port_id=port_id)
+     def port_delete(self, context, port_id):
+         cctxt = self.client.prepare(topic=self.topic_port_delete, fanout=True)
+         cctxt.cast(context, 'port_delete', port_id=port_id)
  
  I think neutron-server should directly sends the RPC message to port's
  binding_host, this can offload work for AMQP

** Description changed:

  Now for ml2 plugin,  neutron-server use faout RPC  message for port_update and port_delete, the codes as below:
-     def port_update(self, context, port, network_type, segmentation_id, physical_network):
+     def port_update(self, context, port, network_type, segmentation_id,          physical_network):
          cctxt = self.client.prepare(topic=self.topic_port_update,fanout=True)
          cctxt.cast(context, 'port_update', port=port,
                     network_type=network_type,
-                                       segmentation_id=segmentation_id,
+                    segmentation_id=segmentation_id,
                     physical_network=physical_network)
  
      def port_delete(self, context, port_id):
          cctxt = self.client.prepare(topic=self.topic_port_delete, fanout=True)
          cctxt.cast(context, 'port_delete', port_id=port_id)
  
  I think neutron-server should directly sends the RPC message to port's
  binding_host, this can offload work for AMQP

** Changed in: neutron
     Assignee: (unassigned) => shihanzhang (shihanzhang)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1540748

Title:
  ml2: port_update and port_delete should not use faout notify

Status in neutron:
  New

Bug description:
  Now for ml2 plugin,  neutron-server use faout RPC  message for port_update and port_delete, the codes as below:
      def port_update(self, context, port, network_type, segmentation_id,          physical_network):
          cctxt = self.client.prepare(topic=self.topic_port_update,fanout=True)
          cctxt.cast(context, 'port_update', port=port,
                     network_type=network_type,
                     segmentation_id=segmentation_id,
                     physical_network=physical_network)

      def port_delete(self, context, port_id):
          cctxt = self.client.prepare(topic=self.topic_port_delete, fanout=True)
          cctxt.cast(context, 'port_delete', port_id=port_id)

  I think neutron-server should directly sends the RPC message to port's
  binding_host, this can offload work for AMQP

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1540748/+subscriptions