yahoo-eng-team team mailing list archive

[OpenStack Infra <1540495@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/275401
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=78bfa9727da5e653cd46fbea5f2e348c32905154
Submitter: Jenkins
Branch:    master

commit 78bfa9727da5e653cd46fbea5f2e348c32905154
Author: Victor Stinner <vstinner@xxxxxxxxxx>
Date:   Tue Feb 2 21:43:49 2016 +0100

    Support xvfbwrapper 0.2.8
    
    xvfbwrapper 0.2.8 renamed the xvfb_cmd attribute of xvfbwrapper.Xvfb
    to extra_xvfb_args. This change checks if the new attribute name is
    available to support new and old xvfbwrapper version.
    
    xvfbwrapper commit changing the API:
    https://github.com/cgoldberg/xvfbwrapper/commit/9a8c0e80f6a932d5448d1b97d5a9c316a7a7c8e3
    
    Closes-Bug: #1540495
    Change-Id: I45704450ff396787453937362029945b94887189


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1540495

Title:
  Version 0.2.8 of xvfbwrapper breaks integration tests

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Version 0.2.8 (released on Jan 31) breaks all integration tests with
  stacktrace

  2016-02-01 16:58:10.961 | 2016-02-01 16:58:10.904 |   File "/opt/stack/new/horizon/openstack_dashboard/test/integration_tests/helpers.py", line 160, in setUp
  2016-02-01 16:58:10.961 | 2016-02-01 16:58:10.905 |     super(TestCase, self).setUp()
  2016-02-01 16:58:10.961 | 2016-02-01 16:58:10.907 |   File "/opt/stack/new/horizon/openstack_dashboard/test/integration_tests/helpers.py", line 60, in setUp
  2016-02-01 16:58:10.962 | 2016-02-01 16:58:10.909 |     self.vdisplay.xvfb_cmd.append("-noreset")
  2016-02-01 16:58:10.962 | 2016-02-01 16:58:10.910 | AttributeError: Xvfb instance has no attribute 'xvfb_cmd'

  The solution is to adapt to new version by passing additional
  arguments when initializing Xvfb instance (instead of appending them
  to xvfb_cmd list which doesn't exist now before .start() is invoked).

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1540495/+subscriptions