yahoo-eng-team team mailing list archive

[OpenStack Infra <1533859@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/275912
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0d48617e5744acba94b90f8f6844c9964715691f
Submitter: Jenkins
Branch:    master

commit 0d48617e5744acba94b90f8f6844c9964715691f
Author: Diana Clarke <diana.joan.clarke@xxxxxxxxx>
Date:   Wed Feb 3 15:18:45 2016 -0500

    Test that new tables don't use soft deletes
    
    Soft deletes were deprecated in Mitaka. Whitelist the existing
    tables that use soft deletes, and add a test to make sure no new
    ones are added.
    
    Change-Id: Ibdf0f0e9944a8d3e71ef7411d14f0054ed17e7b6
    Closes-Bug: #1533859


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1533859

Title:
  There should be a DB API test that ensures no new tables have soft-
  delete columns

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  In mitaka we approved a spec to no longer have the SoftDeleteMixin in
  the data model so new tables don't implicitly inherit from that and
  get the deleted and deleted_at columns:

  http://specs.openstack.org/openstack/nova-specs/specs/mitaka/approved
  /no-more-soft-delete.html

  We don't have anything enforcing that policy though, except code
  review, which has failed a few times.

  We should have a db api unit test which basically has a whitelist of
  which tables already have those columns and then we check the models
  against that, and if any new tables are introduced in the model which
  have the deleted or deleted_at columns, they'd fail the test.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1533859/+subscriptions