yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #45890
[Bug 1535327] Re: neutron.common.rpc has no unit test coverage
Reviewed: https://review.openstack.org/268334
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e4f2fb9df652354157c076bdf9b3eff464dcd3ba
Submitter: Jenkins
Branch: master
commit e4f2fb9df652354157c076bdf9b3eff464dcd3ba
Author: Ryan Rossiter <rlrossit@xxxxxxxxxx>
Date: Fri Jan 15 14:15:02 2016 +0000
Add tests for RPC methods/classes
The public methods and classes within the neutron.common.rpc module are
untested. This adds tests for all public-facing functions within the
module.
Closes-Bug: #1535327
Change-Id: I80227dd73e58f8b5dbde9cea01ceac22cc8b2e34
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1535327
Title:
neutron.common.rpc has no unit test coverage
Status in neutron:
Fix Released
Bug description:
The neutron.common.rpc module has no unit test coverage. The following
change was made to neutron/common/rpc.py:
68 def cleanup():
69 global TRANSPORT, NOTIFIER
70 assert TRANSPORT is not None
71 assert NOTIFIER is not None
72 # TRANSPORT.cleanup()
73 # TRANSPORT = NOTIFIER = None
No unit tests failed as a result of L72-73 being commented out,
meaning no unit tests are covering some of the main functionality of
this module. At a minimum, the public functions and classes should be
unit tested.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1535327/+subscriptions
References