yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #46014
[Bug 1542972] Re: linux bridge device processing loop breaks on removals
Reviewed: https://review.openstack.org/277283
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=59d815c704d9adfefe85543b5c89ebb163d5bc44
Submitter: Jenkins
Branch: master
commit 59d815c704d9adfefe85543b5c89ebb163d5bc44
Author: Mr. Bojangles <kevinbenton@xxxxxxxxxxxxx>
Date: Sun Feb 7 21:57:00 2016 -0700
Make add_tap_interface resillient to removal
This patch makes add_tap_interface safe to race conditions
where the interface is removed in the middle of processing
by catching exceptions and checking to see if the interface
still exists. If it no longer exists it assumes the exception
was caused by the missing interface and returns False as it
would if the interface did not exist to begin with.
Change-Id: Ie0d89fc2584490b6985aee66da70bae027a130ed
Closes-bug: #1542972
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1542972
Title:
linux bridge device processing loop breaks on removals
Status in neutron:
Fix Released
Bug description:
The code to handle new interfaces makes a check to see if the
interface exists and then assumes it will exist for the rest of its
operations. This assumption does not hold true because a device can be
removed at any time (by Nova, the agents, whatever). So when a device
is removed at the wrong time it will cause an exception that will
trigger all of the ports to be rewired, which is an expensive
operation and will cause the status of the ports on the server side to
go ACTIVE->BUILD->ACTIVE.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1542972/+subscriptions
References