← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1454921] Re: OVS DVR: KeyError: 'gateway_mac'

 

Reviewed:  https://review.openstack.org/272025
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7b5ba5b35a2c793a21a1f2d336cc339e37eeee2f
Submitter: Jenkins
Branch:    master

commit 7b5ba5b35a2c793a21a1f2d336cc339e37eeee2f
Author: Hong Hui Xiao <xiaohhui@xxxxxxxxxx>
Date:   Mon Jan 25 06:20:49 2016 -0500

    Log warning message if get_subnet_for_dvr fails
    
    When subnet or gateway port has been deleted concurrently, rpc call
    to get_subnet_for_dvr will return an empty dict without any value.
    ovs_dvr_neutron_agent should be more gracefull and at least log
    warning message in that situation.
    
    Change the existing error log to warning, because it is not a server
    error, but a fact that should be noticed.
    
    Change-Id: Icb3a57553a8b0eb635c0d85e2c60e7ce519893f6
    Closes-bug: #1454921


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1454921

Title:
  OVS DVR: KeyError: 'gateway_mac'

Status in neutron:
  Fix Released

Bug description:
  get_subnet_for_dvr RPC returns {} on error.
  OVS agent, namely _bind_centralized_snat_port_on_dvr_subnet, doesn't handle the case gracefully.

  eyJzZWFyY2giOiJtZXNzYWdlOiBcIktleUVycm9yOiAnZ2F0ZXdheV9tYWMnXCIiLCJmaWVsZHMiOltdLCJvZmZzZXQiOjAsInRpbWVmcmFtZSI6Ijg2NDAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTQzMTU3MzExODcxNH0

  [req-4c481831-bcb8-47db-9487-e29eb396e871 None None] Error while processing VIF ports
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent Traceback (most recent call last):
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/opt/stack/new/neutron/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py", line 1641, in rpc_loop
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     ovs_restarted)
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/opt/stack/new/neutron/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py", line 1411, in process_network_ports
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     devices_added_updated, ovs_restarted))
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/opt/stack/new/neutron/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py", line 1318, in treat_devices_added_or_updated
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/opt/stack/new/neutron/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py", line 1220, in treat_vif_port
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     fixed_ips, device_owner, ovs_restarted)
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/opt/stack/new/neutron/neutron/plugins/openvswitch/agent/ovs_neutron_agent.py", line 723, in port_bound
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     device_owner)
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/opt/stack/new/neutron/neutron/plugins/openvswitch/agent/ovs_dvr_neutron_agent.py", line 671, in bind_port_to_dvr
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent   File "/opt/stack/new/neutron/neutron/plugins/openvswitch/agent/ovs_dvr_neutron_agent.py", line 641, in _bind_centralized_snat_port_on_dvr_subnet
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent     (subnet_info['gateway_mac'],
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent KeyError: 'gateway_mac'
  2015-05-13 15:46:44.026 5536 TRACE neutron.plugins.openvswitch.agent.ovs_neutron_agent

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1454921/+subscriptions


References