yahoo-eng-team team mailing list archive

[OpenStack Infra <1543766@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/278089
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d754a830861fb55b047e7b4d43ba7f485fc120dd
Submitter: Jenkins
Branch:    master

commit d754a830861fb55b047e7b4d43ba7f485fc120dd
Author: Chris Dent <cdent@xxxxxxxxxxxxx>
Date:   Tue Feb 9 21:10:23 2016 +0000

    Replace eventlet-based raw socket client with requests
    
    There's no discernable reason why we need to use a raw
    eventlet-based client TestWSGIServerWithSSL to confirm that a
    wsgi server is listening correctly and returning the expected
    response, especially since using eventlet leads to unreliable
    i/o on the socket unless there is an explicit yield before
    asserting the value of the response.
    
    So requests is used to query the servers and verify the response.
    
    Change-Id: I00c1c1e93eb7c66c3370434db4e3e6c00087f8aa
    Closes-Bug: #1543766


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1543766

Title:
  nova.tests.unit.test_wsgi.TestWSGIServerWithSSL fails with
  testtools.matchers._impl.MismatchError: 'OK\r\n' != 'PONG' and
  eventlet 0.18.2

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) kilo series:
  In Progress
Status in OpenStack Compute (nova) liberty series:
  In Progress

Bug description:
  http://logs.openstack.org/04/273104/5/gate/gate-nova-
  python27/0a68bad/console.html#_2016-02-09_18_39_51_792

  2016-02-09 18:39:51.792 | nova.tests.unit.test_wsgi.TestWSGIServerWithSSL.test_two_servers
  2016-02-09 18:39:51.792 | ----------------------------------------------------------------
  2016-02-09 18:39:51.792 | 
  2016-02-09 18:39:51.792 | Captured traceback:
  2016-02-09 18:39:51.792 | ~~~~~~~~~~~~~~~~~~~
  2016-02-09 18:39:51.793 |     Traceback (most recent call last):
  2016-02-09 18:39:51.793 |       File "nova/tests/unit/test_wsgi.py", line 282, in test_two_servers
  2016-02-09 18:39:51.793 |         self.assertEqual(response[-4:], "PONG")
  2016-02-09 18:39:51.793 |       File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 362, in assertEqual
  2016-02-09 18:39:51.793 |         self.assertThat(observed, matcher, message)
  2016-02-09 18:39:51.793 |       File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 447, in assertThat
  2016-02-09 18:39:51.793 |         raise mismatch_error
  2016-02-09 18:39:51.793 |     testtools.matchers._impl.MismatchError: 'OK\r\n' != 'PONG'

  http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22testtools.matchers._impl.MismatchError%3A%20'OK%5C%5C%5C%5Cr%5C%5C%5C%5Cn'%20!%3D%20'PONG'%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1543766/+subscriptions