yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #46070
[Bug 1436579] Re: os_require_quiesce has different meaning between volume backed instances and volume backed instances
Reviewed: https://review.openstack.org/167819
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=94358a166ae5796ba5a7278a0883db42b81f12b2
Submitter: Jenkins
Branch: master
commit 94358a166ae5796ba5a7278a0883db42b81f12b2
Author: Tomoki Sekiyama <tomoki.sekiyama@xxxxxxx>
Date: Wed Mar 25 14:32:32 2015 -0400
libvirt: Make behavior of os_require_quiesce consistent
Currently, os_require_quiesce metadata is used in two meanings.
For volume backed instances, quiescing is always tried on
snapshot, and the metadata specifies whether snapshot should
be aborted if quiescing is failed. For image backed instances
in the libvirt driver, the metadata determines whether quiescing
is invoked or not.
To make the behaviors consistent, this introduces the same logic
as volume backed instances into libvirt image snapshotting.
This also fixes AttributeError during live snapshot introduced by
commit 4f43bbafa4bfc2ab149d5db4eb55320c1602658b.
Change-Id: Iade076c996118e53d085ede9574cdf01c9e97829
Closes-Bug: #1436579
Closes-Bug: #1488565
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1436579
Title:
os_require_quiesce has different meaning between volume backed
instances and volume backed instances
Status in OpenStack Compute (nova):
Fix Released
Bug description:
os_require_quiesce image metadata is used in two different meanings in
volume backed instances and volume backed instances.
For volume backed instances (in nova-api):
Quiescing is always tried on snapshot. The os_require_quiesce
is used to determine whether snapshot should be aborted
when quiescing is failed.
For image backed instances (in the libvirt driver):
The os_require_quiesce metadata is used to determine whether
quiescing is invoked or not (quiescing is invoked only when
os_require_quiesce is set to True).
These behavior should be consistent.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1436579/+subscriptions
References