yahoo-eng-team team mailing list archive

[Timofey Durakov <tdurakov@xxxxxxxxxxxx>]

Public bug reported:

for clean up phase in driver destroy_disks parameter is calculated in compute manager https://github.com/openstack/nova/blob/8615de1bb7afac8ffbd7d9c8f8e7235c49df9b39/nova/compute/manager.py#L5303 like:
 destroy_disks = not is_shared_block_storage
Then in libvirt driver cleanup method there is expression 
https://github.com/openstack/nova/blob/8615de1bb7afac8ffbd7d9c8f8e7235c49df9b39/nova/virt/libvirt/driver.py#L1117

if destroy_disks or is_shared_block_storage:

which doesn't make sense as its tautology and always evaluated  to True.

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: live-migration

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1544103

Title:
  Tautology in libvirt driver cleanup method

Status in OpenStack Compute (nova):
  New

Bug description:
  for clean up phase in driver destroy_disks parameter is calculated in compute manager https://github.com/openstack/nova/blob/8615de1bb7afac8ffbd7d9c8f8e7235c49df9b39/nova/compute/manager.py#L5303 like:
   destroy_disks = not is_shared_block_storage
  Then in libvirt driver cleanup method there is expression 
  https://github.com/openstack/nova/blob/8615de1bb7afac8ffbd7d9c8f8e7235c49df9b39/nova/virt/libvirt/driver.py#L1117

  if destroy_disks or is_shared_block_storage:

  which doesn't make sense as its tautology and always evaluated  to
  True.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1544103/+subscriptions