yahoo-eng-team team mailing list archive

[OpenStack Infra <1538482@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/272990
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=8677f9287761d848d529aed9ecf2cb2800b5418c
Submitter: Jenkins
Branch:    master

commit 8677f9287761d848d529aed9ecf2cb2800b5418c
Author: kairat_kushaev <kkushaev@xxxxxxxxxxxx>
Date:   Wed Jan 27 13:18:27 2016 +0300

    Use url_for from keystoneclient in swift store
    
    glance doesn't pass ServiceCatalog to glance_store
    in user context(glance just passes a list of service endpoints).
    So when  swift multi-tenant store is enabled then there is no
    method url_for for context.service_catalog.
    We can use ServiceCatalog from keystoneclient for these
    purposes and convert this list to ServiceCatalog if url_for
    method is not present.
    Please also note that keystone.middleware converts
    X-Service-Catalog to v2 so we can safely initialize and use
    ServiceCatalogV2 in glance_store.
    
    Closes-Bug: #1538482
    
    Change-Id: I3c4c56e91656f09067d28923ed45595395e9880e


** Changed in: glance-store
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1538482

Title:
  url_for does not exists for service catalog

Status in Glance:
  New
Status in glance_store:
  Fix Released

Bug description:
  Here we introduced url_for method for service_catalog:
  https://review.openstack.org/#/c/250857/

  Unfortunately, we are parsing service_catalog and passing it to glance_store as a list in context:
  https://github.com/openstack/glance/blob/master/glance/api/middleware/context.py#L117

  Because of this current glance_store master is broken when swift multi-tenant store is enabled with an error like this:
  list doesn't have an attribute url_for.
  That happens every time somebody would like to download/upload images.

  
  We also need to pass ServiceCatalog from glance to glance_store. It is better than initializing ServiceCatalog in glance_store. It alos saves a lot time when upgrading from Keystone v2 to v3.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1538482/+subscriptions