← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1440107] Re: Clearing up project assignments makes assumptions that domain_id != project_id

 

Reviewed:  https://review.openstack.org/275706
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=23fc378cac759fa8fea109ed1f42dc85bf90d4fe
Submitter: Jenkins
Branch:    master

commit 23fc378cac759fa8fea109ed1f42dc85bf90d4fe
Author: Clenimar <clenimar.filemon@xxxxxxxxx>
Date:   Tue Feb 9 17:11:33 2016 -0300

    Avoid wrong deletion of domain assignments
    
    The method delete_project_assignments() in assignment backend removes
    all assignments for a project - although the code fails to set the type
    of assignment, and just uses target_id. This patch sets the type of
    assignment (i.e. USER_PROJECT or GROUP_PROJECT) in order to avoid wrong
    deletions when domain_id == project_id.
    
    Closes-Bug: #1440107
    Change-Id: I17487db0e3f9a64868742b33be5958ceb3f8c4bc


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1440107

Title:
  Clearing up project assignments makes assumptions that domain_id !=
  project_id

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  The method delete_project_assignments() in the assignment backends
  removes all assignments for a project - although the code fails to set
  the type of assignment, and just uses target_id.  This is nearly
  always going to be fine, although technically one should also specify
  the type of the assignment in the delete (e.g. USER_PROJECT or
  GROUP_PROJECT).

  https://github.com/openstack/keystone/blob/b819cea41f6cdf34a0bfc18db34188387f07d982/keystone/assignment/backends/sql.py#L368

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1440107/+subscriptions


References