yahoo-eng-team team mailing list archive

[OpenStack Infra <1522317@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/252827
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ed28f129d5cdd680e7b051ccac520c8304920887
Submitter: Jenkins
Branch:    master

commit ed28f129d5cdd680e7b051ccac520c8304920887
Author: Akihiro Motoki <motoki@xxxxxxxxxxxxx>
Date:   Thu Dec 3 17:51:06 2015 +0900

    Use interpolate in JS to allow translators to control word order
    
    String concatenation is not recommended for better translation.
    
    Closes-Bug: #1522317
    Change-Id: Ib90f8e119d330b27023f2ef05bd24b048f1045bb


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1522317

Title:
  string in glance.service.js cannot control the word order in
  translations

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  openstack_dashboard/static/app/core/openstack-service-
  api/glance.service.js

        return suppressError ? promise : promise.error(function() {
          toastService.add('error', gettext('Unable to delete the image with id: ') + imageId);
        });

  String concatenation should not be used.
  https://docs.djangoproject.com/en/1.8/topics/i18n/translation/#interpolate

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1522317/+subscriptions