← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1540254] Re: "#flake8: noqa" is using incorrectly

 

Reviewed:  https://review.openstack.org/274558
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f94463bb53f8799882a8a2df6f92ea3195eb3fc6
Submitter: Jenkins
Branch:    master

commit f94463bb53f8799882a8a2df6f92ea3195eb3fc6
Author: Bo Wang <bo.wang@xxxxxxxxxxxx>
Date:   Mon Feb 1 16:58:54 2016 +0800

    Switch to use "# noqa" correctly
    
    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".
    switch to use "# noqa" and fix the hidden hacking issues.
    
    Change-Id: I1fe747da7a9ab345d0c84a8cb82a8243bf1ee761
    Closes-Bug: #1540254


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1540254

Title:
  "#flake8: noqa" is using incorrectly

Status in Designate:
  In Progress
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in python-heatclient:
  Fix Released
Status in python-novaclient:
  Fix Released

Bug description:
  "# flake8: noqa" option disables all checks for the whole file. To
  disable one line we should use "# noqa".

  Refer to: https://pypi.python.org/pypi/flake8
  https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb

To manage notifications about this bug go to:
https://bugs.launchpad.net/designate/+bug/1540254/+subscriptions


References