← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1522172] Re: add the new precommit event for security groups

 

Reviewed:  https://review.openstack.org/252755
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c24e9da2f82676d9b9d8c28018bf49c8a294121b
Submitter: Jenkins
Branch:    master

commit c24e9da2f82676d9b9d8c28018bf49c8a294121b
Author: Yalei Wang <yalei.wang@xxxxxxxxx>
Date:   Thu Dec 3 21:38:16 2015 +0800

    Add precommit_XXX event for security group and rules
    
    Current BEFORE_CREATE/DELETE/UPDATE event is outside of the DB
    transaction. Unlike the precommit primitive in ML2 mech drivers, they
    don't work in the same DB transaction of resource, so if we want to
    operate the DB in mech driver related to security group, there would be
    more unsync issues if we use BEFORE_XXX event directly. Moving the
    BEFORE_XXX event inside may also break some current codes, as maybe RPC
    call included.
    
    This patch adds new PRECOMMIT_CREATE/DELETE/UPDATE event type for
    callback function, and use it in the securitygroup/rules DB transaction.
    PRECOMMIT_XXX is in the DB transaction and only purpose is to do DB
    operations in its callback. A CallbackFailure will be triggered when
    exception comes from the callback of the new event.
    
    Change-Id: Icd2849bd84dab6733a572e8c85f242afcefc6c78
    Closes-Bug: #1522172


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1522172

Title:
  add the new precommit event for security groups

Status in neutron:
  Fix Released

Bug description:
  Neutron has already been able to make the agentless driver receive the security
  group BEFORE/AFTER event by neutron callback logic. But this logic still
  lacks the precommit function, like in Ml2 mechanism driver, which guarantees that the
  mechanism driver DB and neutron DB operation are in the same transaction.
  Because the MD may want to have the event callback function and hope its own DB
  operation in the same transaction with neutron securitygroup db.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1522172/+subscriptions


References