← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1546158] [NEW] Table actions with non-unique names cause horizon to incorrectly bind them to a table

 

Public bug reported:

If you define two different actions with the same name and place one of them into table_actions and the other into row_action, horizon will place them non-deterministically,  because horizon.tables.base.DataTable class relies on the Action.name attribute https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L1389
https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L1124

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1546158

Title:
  Table actions with non-unique names cause horizon to incorrectly bind
  them to a table

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  If you define two different actions with the same name and place one of them into table_actions and the other into row_action, horizon will place them non-deterministically,  because horizon.tables.base.DataTable class relies on the Action.name attribute https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L1389
  https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L1124

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1546158/+subscriptions


Follow ups