← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1546433] [NEW] nova.service.Service.kill() is unused and orphaned

 

Public bug reported:

oslo.service.Service doesn't provide kill method in it's interface [1].
Nova is implementing it (it removes service record from the DB), but
obviously it isn't actually ever called. This was probably orphaned long
time ago (last changes in 2011).

I think the method should go away.

[1]
https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L88-L109

** Affects: nova
     Importance: Undecided
     Assignee: Roman Dobosz (roman-dobosz)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Roman Dobosz (roman-dobosz)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1546433

Title:
  nova.service.Service.kill() is unused and orphaned

Status in OpenStack Compute (nova):
  New

Bug description:
  oslo.service.Service doesn't provide kill method in it's interface [1].
  Nova is implementing it (it removes service record from the DB), but
  obviously it isn't actually ever called. This was probably orphaned long
  time ago (last changes in 2011).

  I think the method should go away.

  [1]
  https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L88-L109

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1546433/+subscriptions


Follow ups