yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #46406
[Bug 1544522] Re: Don't use Mock.called_once_with that does not exist
Reviewed: https://review.openstack.org/281252
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=a924151906eab93d7455688337cf08415c56058e
Submitter: Jenkins
Branch: master
commit a924151906eab93d7455688337cf08415c56058e
Author: Chaozhe.Chen <chaozhe.chen@xxxxxxxxxxxx>
Date: Wed Feb 17 20:54:46 2016 +0800
Test: Stop using non-existent method of Mock
There is no method called_once_with() in Mock object.
Use assert_called_once_with() instead.
And called_once_with() does nothing because it's a mock object.
In case 'test_setup_with_no_lbaas', method iterate_per_tenants() will
not be called when setup with no lbass, so use assert_not_called()
instead.
Change-Id: Ib25b325b8764e6f0e0928f46f4789fce0f04b9e1
Closes-Bug: #1544522
** Changed in: rally
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1544522
Title:
Don't use Mock.called_once_with that does not exist
Status in Cinder:
Fix Released
Status in neutron:
In Progress
Status in octavia:
In Progress
Status in python-designateclient:
In Progress
Status in Rally:
Fix Released
Status in Sahara:
Fix Released
Status in Trove:
In Progress
Bug description:
class mock.Mock does not exist method "called_once_with", it just
exists method "assert_called_once_with". Currently there are still
some places where we use called_once_with method, we should correct
it.
NOTE: called_once_with() does nothing because it's a mock object.
To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1544522/+subscriptions