← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1545655] Re: A close icon in the upper right don't show in Update Metadata

 

Reviewed:  https://review.openstack.org/280133
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=de30e3c7d3c6ac1287bfd88af7abc58d13c1c1d9
Submitter: Jenkins
Branch:    master

commit de30e3c7d3c6ac1287bfd88af7abc58d13c1c1d9
Author: Kenji Ishii <ken-ishii@xxxxxxxxxxxxx>
Date:   Mon Feb 15 19:10:04 2016 +0900

    Add a close icon in the upper right in Update Metadata modal
    
    Other modal dialog have this icon but Update Metadata dialog
    don't have it. This patch will fix it.
    
    Change-Id: I6f7bc243d3ef5e48fc68fbd0000fa1dcc39b51df
    Closes-Bug: #1545655


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1545655

Title:
  A close icon in the upper right don't show in Update Metadata

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  A close icon in the upper right can close modal dialog.
  Other modal dialog have this icon but Update Metadata dialog don't have it.
  When we use a browser with not maximize window, it often needs a scroll operation.
  Therefore it is better to add icon in the upper right to cancel the modal, same as other modals.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1545655/+subscriptions


References