yahoo-eng-team team mailing list archive

[OpenStack Infra <1495669@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/266989
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=7b6364a4f85e93ac77f740e654b681dfbd47e1f8
Submitter: Jenkins
Branch:    master

commit 7b6364a4f85e93ac77f740e654b681dfbd47e1f8
Author: Boris Bobrov <bbobrov@xxxxxxxxxxxx>
Date:   Wed Jan 13 18:26:51 2016 +0300

    Use the driver to get limits
    
    @response_truncated was used to set the limit of returned entries. It
    asked the driver about the limit and set it to hints. With
    domain-specific configs, there are multiple driver instances and each of
    them carries domain-specific config.
    
    However, with domain-specific configs, the driver is not yet configured
    at that point, because sometimes the manager needs to perform additional
    actions in order to understand what domain it works with. Because of
    that, @response_truncated always got the limit from the default driver,
    not from the one actually used for the domain.
    
    Move the logic of setting the limit from the decorator to a private
    method, call it after determining the domain and driver.
    
    Change-Id: I1748d491b047e33712380da731c272f9d471ec0a
    Closes-Bug: 1495669


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1495669

Title:
  domain-specific drivers does not honor the list_limit set in domain-
  specific conf file

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  Step to reproduce:

  1. enable domain_specific drivers in keystone.conf

    domain_specific_drivers_enabled = true
    domain_configurations_from_database = false
    domain_config_dir = /etc/keystone/domains

  2. set the global list_limit to 2 in keystone.conf

    [default]
    list_limit = 2

  3. create a new domain, along with the corresponding domain-specific
  conf in /etc/keystone/domains/ and set the list_limit to 3 at the
  driver level

  [identity]
  driver = ldap
  list_limit = 5

  [ldap]

  url = ldap://localhost
  ...

  4. restart Keystone and do user list for the specific domain and
  notice that only 2 users are returned

  
  Interestingly, the list_limit set in the [identity] section in keystone.conf works.  i.e.

    [default]
    list_limit = 2

    [identity]
    list_limit = 5

  We just can't override it in the domain-specific conf file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1495669/+subscriptions