← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1540254] Re: "#flake8: noqa" is using incorrectly

 

Reviewed:  https://review.openstack.org/281778
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=8b5fcdb21fe0f07e674498b31fcedfa831e8d068
Submitter: Jenkins
Branch:    master

commit 8b5fcdb21fe0f07e674498b31fcedfa831e8d068
Author: Bo Wang <bo.wang@xxxxxxxxxxxx>
Date:   Thu Feb 18 19:37:56 2016 +0800

    Remove incorrectly used "# flake8: noqa"
    
    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".
    Remove unused "# flake8: noqa" and fix hidden hacking errors.
    
    Change-Id: I8b26cb0e7e5ad4a838099c7aa3ced31b96f28ca2
    Closes-Bug: #1540254


** Changed in: murano
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1540254

Title:
  "#flake8: noqa" is using incorrectly

Status in Designate:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in Murano:
  Fix Released
Status in python-heatclient:
  Fix Released
Status in python-novaclient:
  Fix Released

Bug description:
  "# flake8: noqa" option disables all checks for the whole file. To
  disable one line we should use "# noqa".

  Refer to: https://pypi.python.org/pypi/flake8
  https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb

To manage notifications about this bug go to:
https://bugs.launchpad.net/designate/+bug/1540254/+subscriptions


References