← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1512636] Re: VLAN tag information is added to "port" after calling the agent setup port function

 

Reviewed:  https://review.openstack.org/272513
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b83fedbd78a441cf34d53dba35a3ccff7d8f4ac5
Submitter: Jenkins
Branch:    master

commit b83fedbd78a441cf34d53dba35a3ccff7d8f4ac5
Author: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@xxxxxxxxx>
Date:   Tue Jan 26 12:45:22 2016 +0000

    Add VLAN tag info to port before applying SG initial setup.
    
    Before the initial SG firewall setup, the VLAN tag is added to
    the port information; this assignment is removed from _bind_devices
    function. This value is needed by some SG agent
    implementations.
    
    This implementation mantains the actual function call order:
      - Apply security groups.
      - Bind devices.
    
    Change-Id: I6f70083a1d42a5be4545956406a96d6579145c00
    Closes-Bug: #1512636


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1512636

Title:
  VLAN tag information is added to "port" after calling the agent setup
  port function

Status in neutron:
  Fix Released

Bug description:
  Description:
  During the creation or modification of a neutron port, in the ovs_neutron_agent, the OVS tag information is added to the port after calling the SG agent function to setup the port.

  Pre-conditions:
  File: neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py
  Funtion: process_network_ports

  Step-by-step:
  During the creation or the modification of a neutron port, the following calls are made:
  - treat_devices_added_or_updated
  - sg_agent.setup_port_filters
  - _bind_devices

  The problem is the "port" variable if fulfilled with the VLAN OVS tag
  information during the _bind_devices call. This information is needed
  for some OVS SG driver implementations, for example
  https://review.openstack.org/#/c/240957/.

  Proposed solution:
  Call _bind_devides before the sg_agent call.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1512636/+subscriptions


References