yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #46569
[Bug 1398629] Re: Fix buggy tests that use REQUIRES_LOCKING=True
A bug for this isn't really helping get this work done. This is just one
of those non bug test cleanup efforts.
** Changed in: nova
Status: Confirmed => Opinion
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1398629
Title:
Fix buggy tests that use REQUIRES_LOCKING=True
Status in OpenStack Compute (nova):
Opinion
Bug description:
from https://github.com/openstack/nova/blob/master/nova/test.py#L311
# NOTE(sdague): because of the way we were using the lock
# wrapper we eneded up with a lot of tests that started
# relying on global external locking being set up for them. We
# consider all of these to be *bugs*. Tests should not require
# global external locking, or if they do, they should
# explicitly set it up themselves.
#
# The following REQUIRES_LOCKING class parameter is provided
# as a bridge to get us there. No new tests should be added
# that require it, and existing classes and tests should be
# fixed to not need it.
We need to fix the tests that use REQUIRES_LOCKING = True.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1398629/+subscriptions
References