yahoo-eng-team team mailing list archive

[OpenStack Infra <1544522@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/281230
Committed: https://git.openstack.org/cgit/openstack/python-designateclient/commit/?id=607bef280c19a8842ff97629d65bbf8ddf288845
Submitter: Jenkins
Branch:    master

commit 607bef280c19a8842ff97629d65bbf8ddf288845
Author: Chaozhe.Chen <chaozhe.chen@xxxxxxxxxxxx>
Date:   Wed Feb 17 11:49:22 2016 +0800

    Stop using non-existent method of Mock
    
    There is no method called_once_with() in Mock object.
    Use assert_called_once_with() instead.
    
    I tested it in my tox environment. The revised assertion will work.
    
    Change-Id: I530b58a434b4c031d236b0b04e8c7091854c992f
    Closes-Bug: #1544522


** Changed in: python-designateclient
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1544522

Title:
  Don't use Mock.called_once_with that does not exist

Status in Cinder:
  Fix Released
Status in neutron:
  Fix Released
Status in octavia:
  In Progress
Status in python-designateclient:
  Fix Released
Status in python-openstackclient:
  In Progress
Status in Rally:
  Fix Released
Status in Sahara:
  Fix Released
Status in Trove:
  In Progress

Bug description:
  class mock.Mock does not exist method "called_once_with", it just
  exists method "assert_called_once_with". Currently there are still
  some places where we use called_once_with method, we should correct
  it.

  NOTE: called_once_with() does nothing because it's a mock object.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1544522/+subscriptions