yahoo-eng-team team mailing list archive

[Steve Martinelli <stevemar@xxxxxxxxxx>]

minor test refactorings don't need bugs

** Changed in: keystone
       Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1350593

Title:
  Some assertValidListResponse methods incorrectly handle 'description'

Status in OpenStack Identity (keystone):
  Invalid

Bug description:
  'description' is usually an optional attribute in Entities (e.g.
  Users, Groups etc.).  When testing the List methods of such entities,
  an assert helper method is often used, e.g.
  assertvalidUserListReponse().  Such assert will call
  asserValidEntityResponse, which in turn will call the generic method
  assertValidEntity for each entity in the response.  This calling
  sequence allows for the ability of the top level list assertion method
  to specific which key fields to check - but if no specification is
  given then it will check for 'name', 'description' and 'enabled.
  Since 'description' is optional for most entities, we should not
  require this to be valid in the any of the entities in the list.  This
  can lead to strange unit test problems when entities created (with a
  'description') by a test will cause  list response check to fail.

  This bug was original found by Alexey Miroshkin.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1350593/+subscriptions