yahoo-eng-team team mailing list archive

[Wenjun Wang <10191230@xxxxxxxxxx>]

Public bug reported:

the code:
https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/shell.py#L149

https://github.com/openstack/python-
glanceclient/blob/master/glanceclient/common/utils.py#L215

if we provide image's id,find_resource() will return an object which
contains detail info of this image.

if we provide image's name,find_resource() will return an object which
contains general info of this image,but image's id is in this info,then
we use image's id to get detail info of this image.

it's not need to get twice info if we provide image's id.we can optimize
the method

** Affects: glance
     Importance: Undecided
     Assignee: Wenjun Wang (10191230-b)
         Status: Confirmed

** Changed in: glance
     Assignee: (unassigned) => Wenjun Wang (10191230-b)

** Changed in: glance
       Status: New => Confirmed

** Description changed:

  the code:
  https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/shell.py#L149
  
  https://github.com/openstack/python-
  glanceclient/blob/master/glanceclient/common/utils.py#L215
  
  if we provide image's id,find_resource() will return image's object
  which contains detail info of this image.
  
  if we provide image's name,find_resource() will return image's object
  which contains general info of this image,but image's id is in this
  info,then we use image's id to get detail info of this image.
  
- it's not need to get twice info if we provide image's id.
+ it's not need to get twice info if we provide image's id.we can optimize
+ the method

** Description changed:

  the code:
  https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/shell.py#L149
  
  https://github.com/openstack/python-
  glanceclient/blob/master/glanceclient/common/utils.py#L215
  
- if we provide image's id,find_resource() will return image's object
- which contains detail info of this image.
+ if we provide image's id,find_resource() will return an object which
+ contains detail info of this image.
  
- if we provide image's name,find_resource() will return image's object
- which contains general info of this image,but image's id is in this
- info,then we use image's id to get detail info of this image.
+ if we provide image's name,find_resource() will return an object which
+ contains general info of this image,but image's id is in this info,then
+ we use image's id to get detail info of this image.
  
  it's not need to get twice info if we provide image's id.we can optimize
  the method

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1548200

Title:
  'image-show' get image info twice in glanceclient v1

Status in Glance:
  Confirmed

Bug description:
  the code:
  https://github.com/openstack/python-glanceclient/blob/master/glanceclient/v1/shell.py#L149

  https://github.com/openstack/python-
  glanceclient/blob/master/glanceclient/common/utils.py#L215

  if we provide image's id,find_resource() will return an object which
  contains detail info of this image.

  if we provide image's name,find_resource() will return an object which
  contains general info of this image,but image's id is in this
  info,then we use image's id to get detail info of this image.

  it's not need to get twice info if we provide image's id.we can
  optimize the method

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1548200/+subscriptions