yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #46779
[Bug 1533216] Re: item allocator should return same value for same key
Reviewed: https://review.openstack.org/266379
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=334dae0190f239a2cba4cebb9f8881e3817cee61
Submitter: Jenkins
Branch: master
commit 334dae0190f239a2cba4cebb9f8881e3817cee61
Author: venkata anil <anil.venkata@xxxxxxxxxxxx>
Date: Tue Jan 12 13:40:36 2016 +0000
item allocator should return same value for same key
When ItemAllocator.allocate called with same key again,
it is returning different value.
To fix this, we check if a value for key already exists in
self.allocations, and return that value if already exists.
Closes-bug: #1533216
Change-Id: I1f6191b07d33a1f542de18a942cefaf7ecb6c143
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1533216
Title:
item allocator should return same value for same key
Status in neutron:
Fix Released
Bug description:
When ItemAllocator.allocate[1] called with same key again,
it is returning different value.
So in dvr, if allocate_rule_priority() called again with same key, it is returning different priority value.
So trying to add same ip rule again is succeeding as we got different priority from allocate_rule_priority(for same key).
As a consequence we will have same ip rule in router namespace but with different priorities.
[1]
https://github.com/openstack/neutron/blob/master/neutron/agent/l3/item_allocator.py#L51
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1533216/+subscriptions
References