yahoo-eng-team team mailing list archive

[Matthew Booth <mbooth@xxxxxxxxxx>]

Public bug reported:

In finish_migration(), after resize the driver does:

            if info['type'] == 'raw' and CONF.use_cow_images:
                self._disk_raw_to_qcow2(info['path'])

This ensures that if use_cow_images is set to True, all raw disks will
be converted to qcow2. This includes config disks, which isn't the
intention here.

A second part of this bug is that config disks are then subsequently
overwritten, which also doesn't seem to be intentional. This is why this
hasn't previously come to light. It is currently just very efficient: we
copy the config disk, convert it to qcow2, then overwrite it with a new
one. We should stop after the original copy.

This code was added here: https://review.openstack.org/#/c/78626/ . I
have read the change, the bug it related to, spoken to the original
author, and one of the core reviewers. None of us could work out why the
above code was there.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1548884

Title:
  libvirt driver converts config drives to qcow2 during resize/migrate

Status in OpenStack Compute (nova):
  New

Bug description:
  In finish_migration(), after resize the driver does:

              if info['type'] == 'raw' and CONF.use_cow_images:
                  self._disk_raw_to_qcow2(info['path'])

  This ensures that if use_cow_images is set to True, all raw disks will
  be converted to qcow2. This includes config disks, which isn't the
  intention here.

  A second part of this bug is that config disks are then subsequently
  overwritten, which also doesn't seem to be intentional. This is why
  this hasn't previously come to light. It is currently just very
  efficient: we copy the config disk, convert it to qcow2, then
  overwrite it with a new one. We should stop after the original copy.

  This code was added here: https://review.openstack.org/#/c/78626/ . I
  have read the change, the bug it related to, spoken to the original
  author, and one of the core reviewers. None of us could work out why
  the above code was there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1548884/+subscriptions