yahoo-eng-team team mailing list archive

[lvmxh <shaohef@xxxxxxx>]

Public bug reported:

now the migration status in nova is hard-code.

They are defined arbitrary.  
Such as, we need a "cancelled" status, then we defined it where where want.

1. firstly 
this is not a good program style. 

2. this is error prone. 
such as we need a list of in-progress status migrations.
we need to do the follow command to summarize all migration status firstly.
this is easy to missing some status. 

$ git grep "mig.*status"
......
nova/compute/api.py:        migration.status = 'confirming'
nova/compute/api.py:        mig.status = 'finished'
nova/compute/api.py:        if migration.status != 'running':
nova/compute/api.py:                                                  state=migration.status,
nova/compute/manager.py:                # decorated function, migration status should be set to
nova/compute/manager.py:                # 'error', without checking current migration status.
nova/compute/manager.py:                    status = migration.status
nova/compute/manager.py:                migration.status = 'error'
......

** Affects: nova
     Importance: Undecided
     Assignee: lvmxh (shaohef)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => lvmxh (shaohef)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1549558

Title:
  centralize all migration status together

Status in OpenStack Compute (nova):
  New

Bug description:
  now the migration status in nova is hard-code.

  They are defined arbitrary.  
  Such as, we need a "cancelled" status, then we defined it where where want.

  1. firstly 
  this is not a good program style. 

  2. this is error prone. 
  such as we need a list of in-progress status migrations.
  we need to do the follow command to summarize all migration status firstly.
  this is easy to missing some status. 

  $ git grep "mig.*status"
  ......
  nova/compute/api.py:        migration.status = 'confirming'
  nova/compute/api.py:        mig.status = 'finished'
  nova/compute/api.py:        if migration.status != 'running':
  nova/compute/api.py:                                                  state=migration.status,
  nova/compute/manager.py:                # decorated function, migration status should be set to
  nova/compute/manager.py:                # 'error', without checking current migration status.
  nova/compute/manager.py:                    status = migration.status
  nova/compute/manager.py:                migration.status = 'error'
  ......

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1549558/+subscriptions