← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1490571] Re: Refactor use of oslo.db.sqlalchemy.session.EngineFacade because it's deprecated

 

Reviewed:  https://review.openstack.org/284516
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=8f432e9b4492ff474c16fbcd48b33e8f5aa0e661
Submitter: Jenkins
Branch:    master

commit 8f432e9b4492ff474c16fbcd48b33e8f5aa0e661
Author: Morgan Fainberg <morgan.fainberg@xxxxxxxxx>
Date:   Wed Feb 24 19:29:20 2016 -0800

    No more legacy engine facade in tests
    
    Do not use the legacy engine facade from oslo_db even in testing.
    
    Change-Id: I70d0724679a5fd5cd3ace54e4ae44957c2277daf
    Closes-Bug: #1490571


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1490571

Title:
  Refactor use of oslo.db.sqlalchemy.session.EngineFacade because it's
  deprecated

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  OsloDBDeprecationWarning shows up in many gerrit patches' gate-keystone-python27 console logs.
  <snip>
  ...
  2015-08-31 11:12:43.194 | {2} keystone.tests.unit.backend.domain_config.test_sql.SqlDomainConfigModels.test_whitelisted_model [0.467583s] ... ok
  2015-08-31 11:12:43.194 | 
  2015-08-31 11:12:43.194 | Captured stderr:
  2015-08-31 11:12:43.194 | ~~~~~~~~~~~~~~~~
  2015-08-31 11:12:43.194 |     /home/jenkins/workspace/gate-keystone-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_db/sqlalchemy/enginefacade.py:1015: OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo.db.sqlalchemy.enginefacade
  2015-08-31 11:12:43.195 |       expire_on_commit=expire_on_commit, _conf=conf)
  2015-08-31 11:12:43.195 |     
  2015-08-31 11:12:43.195 | {2} keystone.tests.unit.backend.role.test_ldap.LdapIdentitySqlEverythingElseRole.test_list_roles [0.319631s] ... ok
  ...
  </snip>

  Few instances:
  https://review.openstack.org/#/c/217340/
  http://logs.openstack.org/40/217340/2/check/gate-keystone-python27/4cfcaaf/console.html

  https://review.openstack.org/#/c/210456/
  http://logs.openstack.org/56/210456/6/check/gate-keystone-python27/da1ad9f/console.html

  https://review.openstack.org/#/c/209524/
  http://logs.openstack.org/24/209524/13/check/gate-keystone-python27/8a97dbd/console.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1490571/+subscriptions


References