← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1550277] [NEW] ComputeNode pci pools can't change from not empty to empty.

 

Public bug reported:


1 Node pci_passthrough_whitelist is set to pci device,ComputeNode pci pools can get pools。
2 change pci_passthrough_whitelist empty,ComputeNode pci pools can‘t change
because:

   def _convert_pci_stats_to_db_format(updates):
        pools = updates.pop('pci_device_pools', None)
        if pools:
            updates['pci_stats'] = jsonutils.dumps(pools.obj_to_primitive())

if pools is empty,pci_stats will be do nothing.
That means db will be the old one.

we should be like this:
        if pools:
            updates['pci_stats'] = jsonutils.dumps(pools.obj_to_primitive())
        else
             xxxxxxxxx

** Affects: nova
     Importance: Undecided
     Assignee: Yan Songming (songmingyan)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Yan Songming (songmingyan)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1550277

Title:
  ComputeNode pci pools can't change from not empty to empty.

Status in OpenStack Compute (nova):
  New

Bug description:
  
  1 Node pci_passthrough_whitelist is set to pci device,ComputeNode pci pools can get pools。
  2 change pci_passthrough_whitelist empty,ComputeNode pci pools can‘t change
  because:

     def _convert_pci_stats_to_db_format(updates):
          pools = updates.pop('pci_device_pools', None)
          if pools:
              updates['pci_stats'] = jsonutils.dumps(pools.obj_to_primitive())

  if pools is empty,pci_stats will be do nothing.
  That means db will be the old one.

  we should be like this:
          if pools:
              updates['pci_stats'] = jsonutils.dumps(pools.obj_to_primitive())
          else
               xxxxxxxxx

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1550277/+subscriptions


Follow ups