← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1551542] [NEW] need to check if a plugin's start rpc listeners is supported before trying to start it

 

Public bug reported:

This showed up on a new service plugin being created that did not need
to start rpc workers.  It did not implement the start_rpc_listeners
method so the base class has it raise NotImplemented.

The neutron.service.RpcWorker.start method should check if the plugin
supports it by using the plugin.rpc_workers_supported method.

https://github.com/openstack/neutron/blob/master/neutron/neutron_plugin_base_v2.py#L389-L402


    2016-03-01 11:35:19.983 ERROR oslo_service.service [-] Error starting thread.
    2016-03-01 11:35:19.983 TRACE oslo_service.service Traceback (most recent call last):
    2016-03-01 11:35:19.983 TRACE oslo_service.service   File "/usr/local/lib/python2.7/dist-packages/oslo_service/service.py", line 680, in run_service
    2016-03-01 11:35:19.983 TRACE oslo_service.service     service.start()
    2016-03-01 11:35:19.983 TRACE oslo_service.service   File "/opt/stack/neutron/neutron/service.py", line 142, in start
    2016-03-01 11:35:19.983 TRACE oslo_service.service     servers = getattr(plugin, self.start_listeners_method)()
    2016-03-01 11:35:19.983 TRACE oslo_service.service   File "/opt/stack/neutron/neutron/neutron_plugin_base_v2.py", line 377, in start_rpc_listeners
    2016-03-01 11:35:19.983 TRACE oslo_service.service     raise NotImplementedError()
    2016-03-01 11:35:19.983 TRACE oslo_service.service NotImplementedError
    2016-03-01 11:35:19.983 TRACE oslo_service.service

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1551542

Title:
  need to check if a plugin's start rpc listeners is supported before
  trying to start it

Status in neutron:
  New

Bug description:
  This showed up on a new service plugin being created that did not need
  to start rpc workers.  It did not implement the start_rpc_listeners
  method so the base class has it raise NotImplemented.

  The neutron.service.RpcWorker.start method should check if the plugin
  supports it by using the plugin.rpc_workers_supported method.

  https://github.com/openstack/neutron/blob/master/neutron/neutron_plugin_base_v2.py#L389-L402

  
      2016-03-01 11:35:19.983 ERROR oslo_service.service [-] Error starting thread.
      2016-03-01 11:35:19.983 TRACE oslo_service.service Traceback (most recent call last):
      2016-03-01 11:35:19.983 TRACE oslo_service.service   File "/usr/local/lib/python2.7/dist-packages/oslo_service/service.py", line 680, in run_service
      2016-03-01 11:35:19.983 TRACE oslo_service.service     service.start()
      2016-03-01 11:35:19.983 TRACE oslo_service.service   File "/opt/stack/neutron/neutron/service.py", line 142, in start
      2016-03-01 11:35:19.983 TRACE oslo_service.service     servers = getattr(plugin, self.start_listeners_method)()
      2016-03-01 11:35:19.983 TRACE oslo_service.service   File "/opt/stack/neutron/neutron/neutron_plugin_base_v2.py", line 377, in start_rpc_listeners
      2016-03-01 11:35:19.983 TRACE oslo_service.service     raise NotImplementedError()
      2016-03-01 11:35:19.983 TRACE oslo_service.service NotImplementedError
      2016-03-01 11:35:19.983 TRACE oslo_service.service

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1551542/+subscriptions


Follow ups