← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1517081] Re: Angular and Python tables look very different

 

Reviewed:  https://review.openstack.org/246625
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b69ff722c17a25637c6c95426f6096474fddf10b
Submitter: Jenkins
Branch:    master

commit b69ff722c17a25637c6c95426f6096474fddf10b
Author: Rob Cresswell <robert.cresswell@xxxxxxxxxxx>
Date:   Wed Jan 27 11:26:29 2016 +0000

    Match python/ angular table styles
    
    This patch unifies the Python and Angular table styles (there is no
    reason for them to look drastically different).
    
    - Clean up table header in _data_table.html
    - Remove page_header styling for default theme, as it causes the angular
      panels to shift downwards on the page
    - Removed styling workarounds from default themes
    - Removed several chunks of angular specific scss code, including the
      'modern' class
    - Removed the "Actions" header in python tables, to match Angular
    - Removed duplicate 'no items to display' info in footer, when table is
      empty.
    - Also fixes the Containers header, which was different to all the
      others
    
    Closes-Bug: 1517081
    Co-Authored-By: Diana Whitten <hurgleburgler@xxxxxxxxx>
    Change-Id: Id71aab6e8bbbcd1f7fa4d5575156e4d3c6aa990d


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1517081

Title:
  Angular and Python tables look very different

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The new Angular tables look quite different to the Python/ Django
  ones. The styles should be as similar as possible.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1517081/+subscriptions


References