← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1508880] Re: Safely encode checksum to use glance with apache

 

Reviewed:  https://review.openstack.org/238130
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=ba234c1d79a089cacee03fa517a880081b730eb7
Submitter: Jenkins
Branch:    master

commit ba234c1d79a089cacee03fa517a880081b730eb7
Author: kairat_kushaev <kkushaev@xxxxxxxxxxxx>
Date:   Wed Oct 21 18:05:38 2015 +0300

    Encode headers to launch glance v2 on mod_wsgi
    
    Some headers in v2 are unicode string and they cannot be
    recognized by mod_wsgi. So encode all headers as utf-8 to allow
    users to use glance under Apache mod_wsgi or other wsgi
    frameworks.  v1 functionality already encoded headers as utf-8.
    
    APIImpact
    Closes-bug: #1508880
    Change-Id: Ifa83ed3ab44a4b7f98e438c74d889a956703cf4a


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1508880

Title:
  Safely encode checksum to use glance with apache

Status in Glance:
  Fix Released

Bug description:
  When trying to download any image under apache+mod_wsgi glance logs responses with Type Error: expected byte str, got unicode without any useful information.
  It seems that one of headers is decoded as unicode which can cause problem on different web-servers (apache is one of examples).
  Steps to reproduce:
  1. Deploy glance-api under apache
  2. try to download any image
  ER: Type Error: expected byte str, got 
  AR: all good

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1508880/+subscriptions


References