yahoo-eng-team team mailing list archive

[OpenStack Infra <1542430@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/277365
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=8415297e5be24700ebeb51dc7cb00deb86527929
Submitter: Jenkins
Branch:    master

commit 8415297e5be24700ebeb51dc7cb00deb86527929
Author: Kirill Zaitsev <k.zaitsev@xxxxxx>
Date:   Mon Feb 8 15:28:18 2016 +0300

    Allow mutable argument to be passed to BinaryObject artifacts
    
    According to spec description [1] binary data should always be
    immutable. Before this commit, passing 'mutable' argument lead
    to exception, because it was passed to a function twice. This commit
    makes BinaryObject's silently ignore mutable=False and raises an
    appropriate exception in case mutable=True is passed.
    
    Change-Id: Ib42871004c792b840f8af0316c3b8177c4ecf706
    Closes-Bug: #1542430


** Changed in: glance
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1542430

Title:
  [artifacts] Setting mutable=False for BLOBs lead to exception

Status in Glance:
  Fix Released

Bug description:
  2016-02-05 20:42:01.198 48899 ERROR glance.common.artifacts.loader     stored_object = definitions.BinaryObject(mutable=False)
  2016-02-05 20:42:01.198 48899 ERROR glance.common.artifacts.loader   File "/Users/teferi/murano/glance/glance/common/artifacts/definitions.py", line 520, in __init__
  2016-02-05 20:42:01.198 48899 ERROR glance.common.artifacts.loader     mutable=False, **kwargs)
  2016-02-05 20:42:01.198 48899 ERROR glance.common.artifacts.loader TypeError: __init__() got multiple values for keyword argument 'mutable'

  Seems that definitions.BinaryObject should always be mutable=False,
  but the error message is misleading. I suggest that this should be a
  warning, not an error. mutable=False can be ignored with an error and
  mutable=True can lead to an Error, that explains, that it's impossible
  to set mutable for BLOB

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1542430/+subscriptions