← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1550623] Re: Functional ARPSpoofTestCase's occasionally fail

 

Reviewed:  https://review.openstack.org/286428
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a6c231cdd731dae900c372799a890407bbc24a2c
Submitter: Jenkins
Branch:    master

commit a6c231cdd731dae900c372799a890407bbc24a2c
Author: Kevin Benton <kevin@xxxxxxxxxx>
Date:   Mon Feb 29 21:28:48 2016 -0800

    Make run_ofctl check for socket error
    
    When the OVS bridge is still being initialized we get
    a "failed to connect to socket" error when running ovs-ofctl.
    This shows up quite frequently in our functional tests and
    may be the source of their high failure rate.
    
    Ultimately we need to change the behavior of run_ofctl to not
    ignore errors by default, but this will require a lot of effort
    because there are many places that likely expect this behavior.
    
    As a workaround, this patch checks for the specific socket failure
    and attempts the command again up to 10 times, sleeping for 1
    second between each attempt to wait for the bridge to be ready.
    
    Closes-Bug: #1550623
    Closes-Bug: #1551593
    Change-Id: I663a54608ed96133014104fe033ecea0a867ac4c


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1550623

Title:
  Functional ARPSpoofTestCase's occasionally fail

Status in neutron:
  Fix Released

Bug description:
  We occasionally get failures in the gate like the one below.
  Unfortunately they are difficult to reproduce locally.

  ft32.3: neutron.tests.functional.agent.test_ovs_flows.ARPSpoofOFCtlTestCase.test_arp_spoof_allowed_address_pairs(native)_StringException: Empty attachments:
    stderr
    stdout

  pythonlogging:'': {{{
  DEBUG [oslo_policy._cache_handler] Reloading cached file /opt/stack/new/neutron/neutron/tests/etc/policy.json
     DEBUG [oslo_policy.policy] Reloaded policy file: /opt/stack/new/neutron/neutron/tests/etc/policy.json
  }}}

  Traceback (most recent call last):
    File "neutron/tests/functional/agent/test_ovs_flows.py", line 202, in test_arp_spoof_allowed_address_pairs
      net_helpers.assert_ping(self.src_namespace, self.dst_addr, count=2)
    File "neutron/tests/common/net_helpers.py", line 102, in assert_ping
      dst_ip])
    File "neutron/agent/linux/ip_lib.py", line 885, in execute
      log_fail_as_error=log_fail_as_error, **kwargs)
    File "neutron/agent/linux/utils.py", line 140, in execute
      raise RuntimeError(msg)
  RuntimeError: Exit code: 1; Stdin: ; Stdout: PING 192.168.0.2 (192.168.0.2) 56(84) bytes of data.

  --- 192.168.0.2 ping statistics ---
  2 packets transmitted, 0 received, 100% packet loss, time 1006ms

  ; Stderr:

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1550623/+subscriptions


References