yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #47298
[Bug 1547362] Re: A driver API for triggering crash dump should abstract an implementation
Reviewed: https://review.openstack.org/282214
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3a0e5f985fdd4b067d68450360cf62d57e82ecb2
Submitter: Jenkins
Branch: master
commit 3a0e5f985fdd4b067d68450360cf62d57e82ecb2
Author: Hironori Shiina <shiina.hironori@xxxxxxxxxxxxxx>
Date: Fri Feb 19 16:32:21 2016 +0900
Abstract a driver API for triggering crash dump
An implementation to trigger crash dump depends on hypervisors. Inject_nmi is
just a libvirt implementation. The driver API name should be
"trigger_crash_dump" for the abstraction.
This patch only changes names of the driver API and an Exception. It has no
functional changes.
Change-Id: Icef57d346fac7f92132bc14e22d5b2652397a64a
Closes-Bug: 1547362
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1547362
Title:
A driver API for triggering crash dump should abstract an
implementation
Status in OpenStack Compute (nova):
Fix Released
Bug description:
We added a new API for triggering crash dump in Mitaka.
At first, "inject_nmi" was proposed as a new API name.
In discussion of the spec[1], we decided to abstract how to trigger crash dump because it depends on hypervisors.
Since the function was partially implemented in Liberty, virt driver has a API named "inject_nmi".
We should change the API name for abstracting an implementation based on the spec approved in Mitaka.
[1] https://review.openstack.org/#/c/229255/
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1547362/+subscriptions
References